diff options
author | Adam <Adam@anope.org> | 2017-03-19 17:26:10 -0400 |
---|---|---|
committer | Adam <Adam@anope.org> | 2017-03-19 17:26:10 -0400 |
commit | f237405a52f6b8efb606c5181ffe3bd75a6a6a8a (patch) | |
tree | 5c81a8fb45c849d824cb5de0a97f383be8cf5bd4 | |
parent | f5cf26cee10612ac46acb7c8c6d2317ef33425c5 (diff) |
Fix some of the simplier compiler warnings
-rw-r--r-- | include/logger.h | 32 | ||||
-rw-r--r-- | include/serialize.h | 2 | ||||
-rw-r--r-- | src/logger.cpp | 2 |
3 files changed, 18 insertions, 18 deletions
diff --git a/include/logger.h b/include/logger.h index eabc9d878..f0b306c40 100644 --- a/include/logger.h +++ b/include/logger.h @@ -172,22 +172,22 @@ class Logger Logger Bot(ServiceBot *bot) const; Logger Bot(const Anope::string &name) const; - template<typename... Args> void Log(LogLevel level, const Anope::string &message, Args&&... args) + template<typename... Args> void Log(LogLevel lev, const Anope::string &message, Args&&... args) { Logger l = *this; l.raw_message = message; - l.level = level; + l.level = lev; Anope::string translated = Language::Translate(message); l.LogMessage(l.Format(translated, std::forward<Args>(args)...)); } - template<typename... Args> void Command(LogType type, CommandSource &source, ChanServ::Channel *ci, const Anope::string &message, Args&&... args) + template<typename... Args> void Command(LogType ltype, CommandSource &csource, ChanServ::Channel *chan, const Anope::string &message, Args&&... args) { Logger l = *this; - l.type = type; - l.SetSource(&source); - l.SetCi(ci); + l.type = ltype; + l.SetSource(&csource); + l.SetCi(chan); // Override if the source is marked override l.CheckOverride(); @@ -196,33 +196,33 @@ class Logger l.LogMessage(l.Format(translated, std::forward<Args>(args)...)); } - template<typename... Args> void Command(LogType type, CommandSource &source, const Anope::string &message, Args&&... args) + template<typename... Args> void Command(LogType ltype, CommandSource &csource, const Anope::string &message, Args&&... args) { - Command(type, source, nullptr, message, std::forward<Args>(args)...); + Command(ltype, csource, nullptr, message, std::forward<Args>(args)...); } // LOG_COMMAND - template<typename... Args> void Command(CommandSource &source, ChanServ::Channel *ci, const Anope::string &message, Args&&... args) + template<typename... Args> void Command(CommandSource &csource, ChanServ::Channel *chan, const Anope::string &message, Args&&... args) { - Command(LogType::COMMAND, source, ci, message, std::forward<Args>(args)...); + Command(LogType::COMMAND, csource, chan, message, std::forward<Args>(args)...); } - template<typename... Args> void Command(CommandSource &source, const Anope::string &message, Args&&... args) + template<typename... Args> void Command(CommandSource &csource, const Anope::string &message, Args&&... args) { - Command(LogType::COMMAND, source, nullptr, message, std::forward<Args>(args)...); + Command(LogType::COMMAND, csource, nullptr, message, std::forward<Args>(args)...); } // LOG_ADMIN - template<typename... Args> void Admin(CommandSource &source, ChanServ::Channel *ci, const Anope::string &message, Args&&... args) + template<typename... Args> void Admin(CommandSource &csource, ChanServ::Channel *chan, const Anope::string &message, Args&&... args) { - Command(LogType::ADMIN, source, ci, message, std::forward<Args>(args)...); + Command(LogType::ADMIN, csource, chan, message, std::forward<Args>(args)...); } - template<typename... Args> void Admin(CommandSource &source, const Anope::string &message, Args&&... args) + template<typename... Args> void Admin(CommandSource &csource, const Anope::string &message, Args&&... args) { - Command(LogType::ADMIN, source, nullptr, message, std::forward<Args>(args)...); + Command(LogType::ADMIN, csource, nullptr, message, std::forward<Args>(args)...); } template<typename... Args> void Log(const Anope::string &message, Args&&... args) diff --git a/include/serialize.h b/include/serialize.h index 10ec14d16..8137e18e9 100644 --- a/include/serialize.h +++ b/include/serialize.h @@ -565,7 +565,7 @@ class Serialize::CommonFieldBase : public FieldTypeBase<T> return this->HasField_(s); } - void Uncache(Object *s) + void Uncache(Object *s) override { Unset_(Upcast(s)); } diff --git a/src/logger.cpp b/src/logger.cpp index d686391d9..22e27d375 100644 --- a/src/logger.cpp +++ b/src/logger.cpp @@ -111,7 +111,7 @@ bool LogInfo::HasType(LogType ltype, LogLevel level, const Anope::string &type) return Anope::Debug ? true : this->debug; case LogLevel::DEBUG_2: case LogLevel::DEBUG_3: - return; + return false; } const std::vector<Anope::string> *list = NULL; |