Rename most ext fields names to be consistent with everything else, add accessors for many

5 files changed, 121 insertions, 14 deletions

diff --git a/include/modules/chanserv/channel.h b/include/modules/chanserv/channel.h
index 3ba5e7561..29e8ef9d7 100644
--- a/include/modules/chanserv/channel.h
+++ b/include/modules/chanserv/channel.h
@@ -27,12 +27,10 @@ class CoreExport Channel : public Serialize::Object
  public:
 	::Channel *c = nullptr;                               /* Pointer to channel, if the channel exists */
 
- protected:
-	using Serialize::Object::Object;
-
- public:
 	static constexpr const char *const NAME = "channel";
 
+	using Serialize::Object::Object;
+
 	virtual Anope::string GetName() anope_abstract;
 	virtual void SetName(const Anope::string &) anope_abstract;
 
@@ -40,10 +38,10 @@ class CoreExport Channel : public Serialize::Object
 	virtual void SetDesc(const Anope::string &) anope_abstract;
 
 	virtual time_t GetTimeRegistered() anope_abstract;
-	virtual void SetTimeRegistered(const time_t &) anope_abstract;
+	virtual void SetTimeRegistered(time_t) anope_abstract;
 
 	virtual time_t GetLastUsed() anope_abstract;
-	virtual void SetLastUsed(const time_t &) anope_abstract;
+	virtual void SetLastUsed(time_t) anope_abstract;
 
 	virtual Anope::string GetLastTopic() anope_abstract;
 	virtual void SetLastTopic(const Anope::string &) anope_abstract;
@@ -52,13 +50,13 @@ class CoreExport Channel : public Serialize::Object
 	virtual void SetLastTopicSetter(const Anope::string &) anope_abstract;
 
 	virtual time_t GetLastTopicTime() anope_abstract;
-	virtual void SetLastTopicTime(const time_t &) anope_abstract;
+	virtual void SetLastTopicTime(time_t) anope_abstract;
 
 	virtual int16_t GetBanType() anope_abstract;
-	virtual void SetBanType(const int16_t &) anope_abstract;
+	virtual void SetBanType(int16_t) anope_abstract;
 
 	virtual time_t GetBanExpire() anope_abstract;
-	virtual void SetBanExpire(const time_t &) anope_abstract;
+	virtual void SetBanExpire(time_t) anope_abstract;
 
 	virtual BotInfo *GetBI() anope_abstract;
 	virtual void SetBI(BotInfo *) anope_abstract;
@@ -66,6 +64,58 @@ class CoreExport Channel : public Serialize::Object
 	virtual ServiceBot *GetBot() anope_abstract;
 	virtual void SetBot(ServiceBot *) anope_abstract;
 
+	/** Whether or not greets are enabled.
+	 */
+	virtual bool IsGreet() anope_abstract;
+	virtual void SetGreet(bool) anope_abstract;
+
+	/** Whether or not fantasy is enabled.
+	 */
+	virtual bool IsFantasy() anope_abstract;
+	virtual void SetFantasy(bool) anope_abstract;
+
+	virtual bool IsNoAutoop() anope_abstract;
+	virtual void SetNoAutoop(bool) anope_abstract;
+
+	virtual bool IsPeace() anope_abstract;
+	virtual void SetPeace(bool) anope_abstract;
+
+	virtual bool IsSecureFounder() anope_abstract;
+	virtual void SetSecureFounder(bool) anope_abstract;
+
+	virtual bool IsRestricted() anope_abstract;
+	virtual void SetRestricted(bool) anope_abstract;
+
+	virtual bool IsSecure() anope_abstract;
+	virtual void SetSecure(bool) anope_abstract;
+
+	virtual bool IsSecureOps() anope_abstract;
+	virtual void SetSecureOps(bool) anope_abstract;
+
+	virtual bool IsSignKick() anope_abstract;
+	virtual void SetSignKick(bool) anope_abstract;
+
+	virtual bool IsSignKickLevel() anope_abstract;
+	virtual void SetSignKickLevel(bool) anope_abstract;
+
+	virtual bool IsNoExpire() anope_abstract;
+	virtual void SetNoExpire(bool) anope_abstract;
+
+	virtual bool IsKeepModes() anope_abstract;
+	virtual void SetKeepModes(bool) anope_abstract;
+
+	virtual bool IsPersist() anope_abstract;
+	virtual void SetPersist(bool) anope_abstract;
+
+	virtual bool IsTopicLock() anope_abstract;
+	virtual void SetTopicLock(bool) anope_abstract;
+
+	virtual bool IsKeepTopic() anope_abstract;
+	virtual void SetKeepTopic(bool) anope_abstract;
+
+	virtual bool IsPrivate() anope_abstract;
+	virtual void SetPrivate(bool) anope_abstract;
+
 	/** Is the user the real founder?
 	 * @param user The user
 	 * @return true or false
@@ -198,4 +248,4 @@ class CoreExport Channel : public Serialize::Object
 };
 
 
-} // namespace ChanServ
\ No newline at end of file
+} // namespace ChanServ
diff --git a/include/modules/memoserv.h b/include/modules/memoserv.h
index 1268facef..8c39b5a5e 100644
--- a/include/modules/memoserv.h
+++ b/include/modules/memoserv.h
@@ -144,6 +144,9 @@ namespace MemoServ
 		virtual int16_t GetMemoMax() anope_abstract;
 		virtual void SetMemoMax(const int16_t &) anope_abstract;
 
+		virtual bool IsHardMax() anope_abstract;
+		virtual void SetHardMax(bool) anope_abstract;
+
 		virtual std::vector<Memo *> GetMemos() anope_abstract;
 		virtual std::vector<Ignore *> GetIgnores() anope_abstract;
 	};
diff --git a/include/modules/nickserv/account.h b/include/modules/nickserv/account.h
index f0ba144f7..511b1220f 100644
--- a/include/modules/nickserv/account.h
+++ b/include/modules/nickserv/account.h
@@ -24,13 +24,13 @@ namespace NickServ
 
 /* A registered account. Each account must have a Nick with the same nick as the
  * account's display.
- * It matters that Base is here before Extensible (it is inherited by Serializable)
  */
 class CoreExport Account : public Serialize::Object
 {
  public:
 	static constexpr const char *const NAME = "account";
 
+#warning "this gets lost"
 	/* Last time an email was sent to this user */
 	time_t lastmail = 0;
 	/* Users online now logged into this account */
@@ -53,6 +53,57 @@ class CoreExport Account : public Serialize::Object
 	virtual Oper *GetOper() anope_abstract;
 	virtual void SetOper(Oper *) anope_abstract;
 
+	virtual Anope::string GetGreet() anope_abstract;
+	virtual void SetGreet(const Anope::string &) anope_abstract;
+
+	virtual bool IsUnconfirmed() anope_abstract;
+	virtual void SetUnconfirmed(bool) anope_abstract;
+
+	virtual bool IsPrivate() anope_abstract;
+	virtual void SetPrivate(bool) anope_abstract;
+
+	virtual bool IsAutoOp() anope_abstract;
+	virtual void SetAutoOp(bool) anope_abstract;
+
+	virtual bool IsKeepModes() anope_abstract;
+	virtual void SetKeepModes(bool) anope_abstract;
+
+	virtual bool IsKillProtect() anope_abstract;
+	virtual void SetKillProtect(bool) anope_abstract;
+
+	virtual bool IsKillQuick() anope_abstract;
+	virtual void SetKillQuick(bool) anope_abstract;
+
+	virtual bool IsKillImmed() anope_abstract;
+	virtual void SetKillImmed(bool) anope_abstract;
+
+	virtual bool IsMsg() anope_abstract;
+	virtual void SetMsg(bool) anope_abstract;
+
+	virtual bool IsSecure() anope_abstract;
+	virtual void SetSecure(bool) anope_abstract;
+
+	virtual bool IsMemoSignon() anope_abstract;
+	virtual void SetMemoSignon(bool) anope_abstract;
+
+	virtual bool IsMemoReceive() anope_abstract;
+	virtual void SetMemoReceive(bool) anope_abstract;
+
+	virtual bool IsMemoMail() anope_abstract;
+	virtual void SetMemoMail(bool) anope_abstract;
+
+	virtual bool IsHideEmail() anope_abstract;
+	virtual void SetHideEmail(bool) anope_abstract;
+
+	virtual bool IsHideMask() anope_abstract;
+	virtual void SetHideMask(bool) anope_abstract;
+
+	virtual bool IsHideStatus() anope_abstract;
+	virtual void SetHideStatus(bool) anope_abstract;
+
+	virtual bool IsHideQuit() anope_abstract;
+	virtual void SetHideQuit(bool) anope_abstract;
+
 	/** Changes the display for this account
 	 * @param na The new display, must be grouped to this account.
 	 */
diff --git a/include/modules/nickserv/ajoin.h b/include/modules/nickserv/ajoin.h
index c23eecbe9..9f060402c 100644
--- a/include/modules/nickserv/ajoin.h
+++ b/include/modules/nickserv/ajoin.h
@@ -25,8 +25,8 @@ class AutoJoin : public Serialize::Object
  public:
 	static constexpr const char *const NAME = "autojoin";
 
-	virtual NickServ::Account *GetOwner() anope_abstract;
-	virtual void SetOwner(NickServ::Account *acc) anope_abstract;
+	virtual NickServ::Account *GetAccount() anope_abstract;
+	virtual void SetAccount(NickServ::Account *acc) anope_abstract;
 
 	virtual Anope::string GetChannel() anope_abstract;
 	virtual void SetChannel(const Anope::string &c) anope_abstract;
diff --git a/include/modules/nickserv/nick.h b/include/modules/nickserv/nick.h
index 604bc02d6..3579e7d0d 100644
--- a/include/modules/nickserv/nick.h
+++ b/include/modules/nickserv/nick.h
@@ -55,6 +55,9 @@ class CoreExport Nick : public Serialize::Object
 
 	virtual Account *GetAccount() anope_abstract;
 	virtual void SetAccount(Account *acc) anope_abstract;
+
+	virtual bool IsNoExpire() anope_abstract;
+	virtual void SetNoExpire(bool) anope_abstract;
 };
 
-} // namespace NickServ
\ No newline at end of file
+} // namespace NickServ