Replace convertTo/stringify with non-throwing alternatives.

Having these throw is terrible for ergonomics and there are loads
of places where the exception was either silently ignored or not
handled at all. Having a function which returns an optional and
another that returns a default works a lot better imo.

1 files changed, 1 insertions, 7 deletions

diff --git a/modules/operserv/os_defcon.cpp b/modules/operserv/os_defcon.cpp
index dbb0edb69..564cfec50 100644
--- a/modules/operserv/os_defcon.cpp
+++ b/modules/operserv/os_defcon.cpp
@@ -192,13 +192,7 @@ public:
 			return;
 		}
 
-		int newLevel = 0;
-		try
-		{
-			newLevel = convertTo<int>(lvl);
-		}
-		catch (const ConvertException &) { }
-
+		auto newLevel = Anope::Convert<int>(lvl, 0);
 		if (newLevel < 1 || newLevel > 5)
 		{
 			this->OnSyntaxError(source, "");