Replace convertTo/stringify with non-throwing alternatives.

Having these throw is terrible for ergonomics and there are loads
of places where the exception was either silently ignored or not
handled at all. Having a function which returns an optional and
another that returns a default works a lot better imo.

1 files changed, 3 insertions, 3 deletions

diff --git a/modules/operserv/os_set.cpp b/modules/operserv/os_set.cpp
index a6cad4f07..b9c948e30 100644
--- a/modules/operserv/os_set.cpp
+++ b/modules/operserv/os_set.cpp
@@ -122,14 +122,14 @@ private:
 		}
 		else
 		{
-			try
+			auto debug = Anope::TryConvert<int>(setting);
+			if (debug.has_value())
 			{
-				Anope::Debug = convertTo<int>(setting);
+				Anope::Debug = debug.value();
 				Log(LOG_ADMIN, source, this) << "DEBUG " << Anope::Debug;
 				source.Reply(_("Services are now in \002debug\002 mode (level %d)."), Anope::Debug);
 				return;
 			}
-			catch (const ConvertException &) { }
 
 			source.Reply(_("Setting for DEBUG must be \002ON\002, \002OFF\002, or a positive number."));
 		}