Memory: Properly initialize and free new module languages.

Memory: Properly free strings in module config directive lookups.

Memory: Do not leak module version and author in rare situations.

Memory: Memory leak when deleting a module callback.

Memory: Memory leaks with module messages.

Memory: Memory leaks with module commands.

Memory: Memory leaks with module event handlers.

Memory: Memory leaks with module event hooks.

Memory: Every module config entry of type string is leaked on config reload.

Memory: Leak services root list, ulines list, host setters list, modules autoload list, modules delayed autoload list, hostserv/memoserv/helpserv/botserv/operserv/chanserv/nickserv core modules lists on config reload.

Memory: Leaks with channel bans/invites/exceptions.

Memory: Leak when updating already existing ignore.

Memory: Invalid pointer read in slists.

Memory: Leak when using /cs appendtopic.

Memory: Leak on (currently impossible) config reload.

Memory: Syscall param write(buf) points to uninitialised byte(s) in save_ns_dbase().

Memory: Leak if PreNickServDB is set and NSEmailReg is not.

Removing a command no longer calls free() on help_param*, reversed previous changes
Changes to CSMaxReg, MSMaxMemos and NewsCount are now properly reflected in help notices after config reload
Small adjustments

Fixed copy&paste mistake

Fix findCommand() searching in the wrong command tables

1 files changed, 8 insertions, 0 deletions

diff --git a/src/events.c b/src/events.c
index 2e9f02904..4a4c0f7c1 100644
--- a/src/events.c
+++ b/src/events.c
@@ -571,6 +571,7 @@ int moduleEventDelHandler(char *name)
     if (debug) {
         displayEvtMessageFromHash(evm->name);
     }
+    destroyEventHandler(evm);
     return status;
 }
 
@@ -596,6 +597,7 @@ int moduleEventDelHook(const char *name)
     if (debug) {
         displayHookFromHash(evh->name);
     }
+    destroyEventHook(evh);
     return status;
 }
 
@@ -641,6 +643,7 @@ int delEventHandler(EvtMessageHash * msgEvtTable[], EvtMessage * evm,
                 } else {
                     msgEvtTable[index] = current->next;
                     free(current->name);
+                    free(current);
                     return MOD_ERR_OK;
                 }
             } else {
@@ -662,6 +665,7 @@ int delEventHandler(EvtMessageHash * msgEvtTable[], EvtMessage * evm,
                 } else {
                     lastHash->next = current->next;
                     free(current->name);
+                    free(current);
                     return MOD_ERR_OK;
                 }
             }
@@ -714,6 +718,7 @@ int delEventHook(EvtHookHash * hookEvtTable[], EvtHook * evh,
                 } else {
                     hookEvtTable[index] = current->next;
                     free(current->name);
+                    free(current);
                     return MOD_ERR_OK;
                 }
             } else {
@@ -735,6 +740,7 @@ int delEventHook(EvtHookHash * hookEvtTable[], EvtHook * evh,
                 } else {
                     lastHash->next = current->next;
                     free(current->name);
+                    free(current);
                     return MOD_ERR_OK;
                 }
             }
@@ -763,6 +769,7 @@ int destroyEventHandler(EvtMessage * evm)
         free(evm->mod_name);
     }
     evm->next = NULL;
+    free(evm);
     return MOD_ERR_OK;
 }
 
@@ -784,5 +791,6 @@ int destroyEventHook(EvtHook * evh)
         free(evh->mod_name);
     }
     evh->next = NULL;
+    free(evh);
     return MOD_ERR_OK;
 }