summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--Changes1
-rw-r--r--src/core/os_oline.c7
2 files changed, 3 insertions, 5 deletions
diff --git a/Changes b/Changes
index 3c1a507ad..935260498 100644
--- a/Changes
+++ b/Changes
@@ -16,6 +16,7 @@ Provided by Anope Dev. <dev@anope.org> - 2006
03/01 F Fixed suspend check on /cs invite. [#429]
03/01 F Fixed memleaks in some protocol files. [#434]
03/01 F Fixed bot check on /bs unassign. [#446]
+03/01 F Fixed wasteful finduser() call in os_oline.c [#457]
Provided by nenolod. <nenolod@nenolod.net> - 2006
02/03 A Support for Charybdis IRCd. [ #00]
diff --git a/src/core/os_oline.c b/src/core/os_oline.c
index 39ae5ae49..3bdad47a0 100644
--- a/src/core/os_oline.c
+++ b/src/core/os_oline.c
@@ -85,11 +85,8 @@ int do_operoline(User * u)
syntax_error(s_OperServ, u, "OLINE", OPER_OLINE_SYNTAX);
return MOD_CONT;
} else {
- u2 = finduser(nick);
-
-/* let's check whether the user is online */
-
- if (!finduser(nick)) {
+ /* let's check whether the user is online */
+ if (!(u2 = finduser(nick))) {
notice_lang(s_OperServ, u, NICK_X_NOT_IN_USE, nick);
} else if (u2 && flags[0] == '+') {
anope_cmd_svso(s_OperServ, nick, flags);