From 0717d63c75496d328ae19ff9482230a63d8fe624 Mon Sep 17 00:00:00 2001 From: cyberbotx Date: Sat, 14 Feb 2009 23:54:34 +0000 Subject: Audited all remaining os_* modules, excluding os_restart (it causes a SIGTRAP that needs to be narrowed down). git-svn-id: http://anope.svn.sourceforge.net/svnroot/anope/trunk@2050 5417fbe8-f217-4b02-8779-1006273d7864 --- TODO | 16 ---------------- src/core/os_admin.c | 8 +++++++- src/core/os_chankill.c | 11 ++++++++++- src/core/os_ignore.c | 2 +- 4 files changed, 18 insertions(+), 19 deletions(-) diff --git a/TODO b/TODO index 20abd82b9..035dc4544 100644 --- a/TODO +++ b/TODO @@ -17,22 +17,6 @@ Legend: [ ] HelpServ must die (1.9.1?) [-] Command parser cleanup: mod_current_buffer needs to go away and be replaced by a proper parser. Commands should then indicate how they want the buffer split. These all need reviewing, remove them from the list _AS YOU GO_. Talk t0 w00t or CBX if you don't know what this is for: - src/core/os_admin.c - src/core/os_chankill.c - src/core/os_chanlist.c - src/core/os_clearmodes.c - src/core/os_defcon.c - src/core/os_help.c - src/core/os_ignore.c - src/core/os_jupe.c - src/core/os_kick.c - src/core/os_mode.c - src/core/os_modlist.c - src/core/os_news.c - src/core/os_noop.c - src/core/os_oline.c - src/core/os_oper.c - src/core/os_quit.c src/core/os_restart.c src/modules/cs_appendtopic.c src/modules/cs_enforce.c diff --git a/src/core/os_admin.c b/src/core/os_admin.c index ad7f6130b..21593d7b7 100644 --- a/src/core/os_admin.c +++ b/src/core/os_admin.c @@ -235,9 +235,15 @@ class CommandOSAdmin : public Command return MOD_CONT; } + bool OnHelp(User *u, const std::string &subcommand) + { + notice_lang(s_OperServ, u, OPER_HELP_ADMIN); + return true; + } + void OnSyntaxError(User *u) { - syntax_error(s_OperServ, u, "ADMIN", OPER_ADMIN_SYNTAX); + syntax_error(s_OperServ, u, "ADMIN", OPER_ADMIN_SYNTAX); } }; diff --git a/src/core/os_chankill.c b/src/core/os_chankill.c index 1c0a8372c..b72e3f2c8 100644 --- a/src/core/os_chankill.c +++ b/src/core/os_chankill.c @@ -88,9 +88,18 @@ class CommandOSChanKill : public Command return MOD_CONT; } + bool OnHelp(User *u, const std::string &subcommand) + { + if (!is_services_admin(u)) + return false; + + notice_lang(s_OperServ, u, OPER_HELP_CHANKILL); + return true; + } + void OnSyntaxError(User *u) { - syntax_error(s_OperServ, u, "CHANKILL", OPER_CHANKILL_SYNTAX); + syntax_error(s_OperServ, u, "CHANKILL", OPER_CHANKILL_SYNTAX); } }; diff --git a/src/core/os_ignore.c b/src/core/os_ignore.c index 294023b3a..b95e7c843 100644 --- a/src/core/os_ignore.c +++ b/src/core/os_ignore.c @@ -98,7 +98,7 @@ class CommandOSIgnore : public Command return MOD_CONT; } public: - CommandOSIgnore() : Command("IGNORE", 1, 4) + CommandOSIgnore() : Command("IGNORE", 1, 3) { } -- cgit