From d3956b71486727dafbe72550f6baec5f4108bf7b Mon Sep 17 00:00:00 2001
From: "certus certus@31f1291d-b8d6-0310-a050-a5561fc1590b"
 <certus certus@31f1291d-b8d6-0310-a050-a5561fc1590b@5417fbe8-f217-4b02-8779-1006273d7864>
Date: Sat, 12 Jun 2004 17:38:02 +0000
Subject: BUILD : 1.7.3 (190) BUGS : 90 NOTES : We check now for valid
 arguments in ModuleAddData().

git-svn-id: svn://svn.anope.org/anope/trunk@190 31f1291d-b8d6-0310-a050-a5561fc1590b


git-svn-id: http://anope.svn.sourceforge.net/svnroot/anope/trunk@135 5417fbe8-f217-4b02-8779-1006273d7864
---
 Changes     | 1 +
 modules.c   | 5 +++++
 version.log | 6 +++++-
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/Changes b/Changes
index d9b11d9e7..d881d14b6 100644
--- a/Changes
+++ b/Changes
@@ -9,6 +9,7 @@ Provided by Anope Dev. <dev@anope.org> - 2004
 05/24 A New NSNickTracking directive to provide nick tracking.            [ #71]
 05/21 A Auto enforce upon AKICK addition.                                 [ #63]
 05/21 A New file docs/OLDCHANGES contains all change history.             [ #65]
+06/12 F We check now for valid arguments in ModuleAddData().              [ #90]
 06/12 F Unified kill_user function to handle all ircd protocols.          [#101]
 06/10 F Added check to see if MysqlUser and MysqlName were not null.      [ #92]
 06/09 F Corrected a number of spelling errors in en_us.l.                 [ #94]
diff --git a/modules.c b/modules.c
index 77eefb2d7..0598a1a22 100644
--- a/modules.c
+++ b/modules.c
@@ -1765,6 +1765,11 @@ int moduleAddData(ModuleData * md[], char *key, char *value)
     ModuleDataItem *lastItem = NULL;
     index = CMD_HASH(mod_name);
 
+    if (!key || !value) {
+        alog("A module tried to use ModuleAddData() with one ore more NULL arguments... returning");
+        return MOD_ERR_PARAMS;
+    }
+
     for (current = md[index]; current; current = current->next) {
         if (strcasecmp(current->moduleName, mod_name) == 0)
             lastHash = current;
diff --git a/version.log b/version.log
index bb61e03bf..07168a89d 100644
--- a/version.log
+++ b/version.log
@@ -8,10 +8,14 @@
 VERSION_MAJOR="1"
 VERSION_MINOR="7"
 VERSION_PATCH="3"
-VERSION_BUILD="189"
+VERSION_BUILD="190"
 
 # $Log$
 #
+# BUILD : 1.7.3 (190)
+# BUGS  : 90
+# NOTES : We check now for valid arguments in ModuleAddData().
+#
 # BUILD : 1.7.3 (189)
 # BUGS  : 95
 # NOTES : Removed duplicate user kill on hybrid.
-- 
cgit