From 332fd239278fe1a80c500a1ea01763e84783057c Mon Sep 17 00:00:00 2001 From: Adam Date: Fri, 15 Nov 2013 15:10:23 -0500 Subject: Add general:hideregisteredcommands to hide commands that require you to be identified to use. This changes the behavior of hideprivilegedcommands to only hide commands users don't have the oper privileges to execute. --- modules/commands/help.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'modules/commands/help.cpp') diff --git a/modules/commands/help.cpp b/modules/commands/help.cpp index ac8c98b09..8d9cce46d 100644 --- a/modules/commands/help.cpp +++ b/modules/commands/help.cpp @@ -44,7 +44,8 @@ class CommandHelp : public Command Anope::string source_command = source.command; const BotInfo *bi = source.service; const CommandInfo::map &map = source.c ? Config->Fantasy : bi->commands; - bool hide_privileged_commands = Config->GetBlock("options")->Get("hideprivilegedcommands"); + bool hide_privileged_commands = Config->GetBlock("options")->Get("hideprivilegedcommands"), + hide_registered_commands = Config->GetBlock("options")->Get("hideregisteredcommands"); if (params.empty() || params[0].equals_ci("ALL")) { @@ -72,11 +73,11 @@ class CommandHelp : public Command ServiceReference c("Command", info.name); if (!c) continue; - else if (!hide_privileged_commands) - ; // Always show with hide_privileged_commands disabled - else if (!c->AllowUnregistered() && !source.GetAccount()) + + if (hide_registered_commands && !c->AllowUnregistered() && !source.GetAccount()) continue; - else if (!info.permission.empty() && !source.HasCommand(info.permission)) + + if (hide_privileged_commands && !info.permission.empty() && !source.HasCommand(info.permission)) continue; if (!info.group.empty() && !all) @@ -145,9 +146,8 @@ class CommandHelp : public Command ServiceReference c("Command", info.name); if (!c) continue; - else if (!hide_privileged_commands) - ; // Always show with hide_privileged_commands disabled - else if (!info.permission.empty() && !source.HasCommand(info.permission)) + + if (hide_privileged_commands && !info.permission.empty() && !source.HasCommand(info.permission)) continue; // Allow unregistered users to see help for commands that they explicitly request help for -- cgit