From 96ccfe4cbe9948206ac2d6854778f9a268d2476f Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Mon, 11 Nov 2024 16:46:56 +0000 Subject: Fix using User::Account where User::IsIdentified should be used. The former causes a dereference which cause a database update. This is not good for performance with db_sql_live on bigger networks. --- modules/commands/ns_set.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'modules/commands/ns_set.cpp') diff --git a/modules/commands/ns_set.cpp b/modules/commands/ns_set.cpp index a3bfb3630..5ec161421 100644 --- a/modules/commands/ns_set.cpp +++ b/modules/commands/ns_set.cpp @@ -1286,7 +1286,7 @@ class NSSet : public Module if (chan->ci) { /* Only give modes if autoop is set */ - give_modes &= !user->Account() || autoop.HasExt(user->Account()); + give_modes &= !user->IsIdentified() || autoop.HasExt(user->Account()); } } @@ -1321,13 +1321,13 @@ class NSSet : public Module void OnUserModeSet(const MessageSource &setter, User *u, const Anope::string &mname) anope_override { - if (u->Account() && setter.GetUser() == u) + if (u->IsIdentified() && setter.GetUser() == u) u->Account()->last_modes = u->GetModeList(); } void OnUserModeUnset(const MessageSource &setter, User *u, const Anope::string &mname) anope_override { - if (u->Account() && setter.GetUser() == u) + if (u->IsIdentified() && setter.GetUser() == u) u->Account()->last_modes = u->GetModeList(); } -- cgit