From 464e6b8010c11708bcbed7cf6b2d972977f0e286 Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Thu, 7 Mar 2024 21:56:58 +0000 Subject: Use the C++11 random number generator instead of rand(). This is safer, faster, and doesn't require seeding. --- modules/encryption/enc_bcrypt.cpp | 2 +- modules/encryption/enc_sha256.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'modules/encryption') diff --git a/modules/encryption/enc_bcrypt.cpp b/modules/encryption/enc_bcrypt.cpp index 76809ed4e..cc255813d 100644 --- a/modules/encryption/enc_bcrypt.cpp +++ b/modules/encryption/enc_bcrypt.cpp @@ -22,7 +22,7 @@ class EBCRYPT final { char entropy[16]; for (auto &chr : entropy) - chr = static_cast(rand() % 0xFF); + chr = static_cast(Anope::RandomNumber() % 0xFF); char salt[32]; if (!_crypt_gensalt_blowfish_rn("$2a$", rounds, entropy, sizeof(entropy), salt, sizeof(salt))) diff --git a/modules/encryption/enc_sha256.cpp b/modules/encryption/enc_sha256.cpp index b9580cd7f..97bd5dd9d 100644 --- a/modules/encryption/enc_sha256.cpp +++ b/modules/encryption/enc_sha256.cpp @@ -249,7 +249,7 @@ class ESHA256 final void NewRandomIV() { for (auto &ivsegment : iv) - ivsegment = static_cast(rand()); + ivsegment = static_cast(Anope::RandomNumber()); } /* returns the IV as base64-encrypted string */ -- cgit