From 29e7674e56bf2b829bba22def2760d034a76e788 Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Mon, 11 Mar 2024 13:53:05 +0000 Subject: Replace convertTo/stringify with non-throwing alternatives. Having these throw is terrible for ergonomics and there are loads of places where the exception was either silently ignored or not handled at all. Having a function which returns an optional and another that returns a default works a lot better imo. --- modules/extra/mysql.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'modules/extra/mysql.cpp') diff --git a/modules/extra/mysql.cpp b/modules/extra/mysql.cpp index 49149464f..72c026dad 100644 --- a/modules/extra/mysql.cpp +++ b/modules/extra/mysql.cpp @@ -452,7 +452,7 @@ Query MySQLService::BuildInsert(const Anope::string &table, unsigned int id, Dat for (const auto &[field, _] : data.data) query_text += ",`" + field + "`"; - query_text += ") VALUES (" + stringify(id); + query_text += ") VALUES (" + Anope::ToString(id); for (const auto &[field, _] : data.data) query_text += ",@" + field + "@"; query_text += ") ON DUPLICATE KEY UPDATE "; @@ -536,7 +536,7 @@ Anope::string MySQLService::BuildQuery(const Query &q) Anope::string MySQLService::FromUnixtime(time_t t) { - return "FROM_UNIXTIME(" + stringify(t) + ")"; + return "FROM_UNIXTIME(" + Anope::ToString(t) + ")"; } void DispatcherThread::Run() -- cgit