From a111b40560bf305653b07d8f7289484793a32588 Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Mon, 24 Feb 2025 03:21:42 +0000 Subject: Allow use of a non-map type as the root RPC element. --- modules/extra/xmlrpc.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'modules/extra') diff --git a/modules/extra/xmlrpc.cpp b/modules/extra/xmlrpc.cpp index 1d9ab7762..681b230dc 100644 --- a/modules/extra/xmlrpc.cpp +++ b/modules/extra/xmlrpc.cpp @@ -116,7 +116,6 @@ public: Anope::string param; if (xmlrpc_value_type(value) != XMLRPC_TYPE_STRING) { - // TODO: error; xmlrpc_env_set_fault(&env, RPC::ERR_INVALID_REQUEST, "Anope XML-RPC only supports strings"); SendError(reply, env); xmlrpc_DECREF(value); @@ -160,8 +159,11 @@ public: return; } - auto *value = xmlrpc_struct_new(&env); - SerializeMap(env, value, request); + xmlrpc_value *value; + if (request.GetRoot()) + value = SerializeElement(env, request.GetRoot().value()); + else + value = xmlrpc_nil_new(&env); auto *response = xmlrpc_mem_block_new(&env, 0); xmlrpc_serialize_response(&env, response, value); -- cgit