From 937404e3118f10735875ff45a658facbf77e984d Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Mon, 5 May 2025 18:00:50 +0100 Subject: Optimise the maths for the jsonrpc oversize integer workaround. --- modules/rpc/jsonrpc.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'modules') diff --git a/modules/rpc/jsonrpc.cpp b/modules/rpc/jsonrpc.cpp index 189e2b3a8..2e8753b8a 100644 --- a/modules/rpc/jsonrpc.cpp +++ b/modules/rpc/jsonrpc.cpp @@ -239,8 +239,7 @@ yyjson_mut_val *JSONRPCServiceInterface::SerializeElement(yyjson_mut_doc *doc, c }, [&doc, &elem](int64_t i) { - auto bits = std::floor(std::log2(abs(i))) + 1; - if (bits <= integer_bits) + if (std::abs(i) < (1LL << integer_bits)) { // We can fit this into an integer. elem = yyjson_mut_int(doc, i); @@ -254,8 +253,7 @@ yyjson_mut_val *JSONRPCServiceInterface::SerializeElement(yyjson_mut_doc *doc, c }, [&doc, &elem](uint64_t u) { - auto bits = std::floor(std::log2(u)) + 1; - if (bits <= integer_bits) + if (u < (1ULL << integer_bits)) { // We can fit this into an integer. elem = yyjson_mut_uint(doc, u); -- cgit