From 1630ccedb11842dbe56d8ce2b9e9f54a53b01b8c Mon Sep 17 00:00:00 2001
From: Sadie Powell <sadie@witchery.services>
Date: Thu, 24 Apr 2025 11:51:37 +0100
Subject: Remove some double lookups in User::BadPassword.

---
 src/users.cpp | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

(limited to 'src/users.cpp')

diff --git a/src/users.cpp b/src/users.cpp
index 0abe0b66e..3d6034691 100644
--- a/src/users.cpp
+++ b/src/users.cpp
@@ -833,14 +833,17 @@ Anope::string User::Mask() const
 
 bool User::BadPassword()
 {
-	if (!Config->GetBlock("options").Get<unsigned int>("badpasslimit"))
+	const auto badpasslimit = Config->GetBlock("options").Get<unsigned>("badpasslimit");
+	if (!badpasslimit)
 		return false;
 
-	if (Config->GetBlock("options").Get<time_t>("badpasstimeout") > 0 && this->invalid_pw_time > 0 && this->invalid_pw_time < Anope::CurTime - Config->GetBlock("options").Get<time_t>("badpasstimeout"))
+	const auto badpasstimeout = Config->GetBlock("options").Get<time_t>("badpasstimeout");
+	if (badpasstimeout > 0 && this->invalid_pw_time > 0 && this->invalid_pw_time < Anope::CurTime - badpasstimeout)
 		this->invalid_pw_count = 0;
+
 	++this->invalid_pw_count;
 	this->invalid_pw_time = Anope::CurTime;
-	if (this->invalid_pw_count >= Config->GetBlock("options").Get<unsigned int>("badpasslimit"))
+	if (this->invalid_pw_count >= badpasslimit)
 	{
 		this->Kill(Me, "Too many invalid passwords");
 		return true;
-- 
cgit