From 4c64c86ef4ddf9ff09c8f51f8a38e20f0513ae8d Mon Sep 17 00:00:00 2001 From: Adam Date: Wed, 6 Oct 2010 16:20:50 -0400 Subject: Fixed a potential crash from accessing invalid memory after unbanning people when checking whether a host is akick stuck. Fixes /cs unban not reapplying stuck ban masks. --- src/actions.c | 9 +++++++-- src/botserv.c | 9 +++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/actions.c b/src/actions.c index e464990aa..35ec93af3 100644 --- a/src/actions.c +++ b/src/actions.c @@ -184,11 +184,16 @@ void common_unban(ChannelInfo * ci, char *nick) entry_match(ban, u->nick, u->username, u->chost, ip)) { anope_cmd_mode(whosends(ci), ci->name, "-b %s", ban->mask); if (ircdcap->tsmode) - av[3] = ban->mask; + av[3] = sstrdup(ban->mask); else - av[2] = ban->mask; + av[2] = sstrdup(ban->mask); do_cmode(whosends(ci), ac, av); + + if (ircdcap->tsmode) + free(av[3]); + else + free(av[2]); } } diff --git a/src/botserv.c b/src/botserv.c index 0b2ad746c..605a0292e 100644 --- a/src/botserv.c +++ b/src/botserv.c @@ -789,11 +789,16 @@ void bot_join(ChannelInfo * ci) anope_cmd_mode(whosends(ci), ci->name, "-b %s", ban->mask); if (ircdcap->tsmode) - av[3] = ban->mask; + av[3] = sstrdup(ban->mask); else - av[2] = ban->mask; + av[2] = sstrdup(ban->mask); do_cmode(whosends(ci), ac, av); + + if (ircdcap->tsmode) + free(av[3]); + else + free(av[2]); } } -- cgit