diff options
| author | geniusdex geniusdex@31f1291d-b8d6-0310-a050-a5561fc1590b <geniusdex geniusdex@31f1291d-b8d6-0310-a050-a5561fc1590b@5417fbe8-f217-4b02-8779-1006273d7864> | 2004-12-30 17:38:35 +0000 |
|---|---|---|
| committer | geniusdex geniusdex@31f1291d-b8d6-0310-a050-a5561fc1590b <geniusdex geniusdex@31f1291d-b8d6-0310-a050-a5561fc1590b@5417fbe8-f217-4b02-8779-1006273d7864> | 2004-12-30 17:38:35 +0000 |
| commit | 2a8bc51cb15fd601a5c16d00be7c526150a28b91 (patch) | |
| tree | 5747b44cef7a900bf3886fae8e6e39864fcbb972 | |
| parent | 35096dbb8ce8ea359a0e929f3312cf1299c8ab20 (diff) | |
BUILD : 1.7.6 (516) BUGS : 261 NOTES : This should be it finally! The moduleAddData function was using the old head to append/prepend the new moduleData to, but it had to use the new head. Thanks to DrStein for finding the cause! :)
git-svn-id: svn://svn.anope.org/anope/trunk@516 31f1291d-b8d6-0310-a050-a5561fc1590b
git-svn-id: http://anope.svn.sourceforge.net/svnroot/anope/trunk@370 5417fbe8-f217-4b02-8779-1006273d7864
| -rw-r--r-- | Changes | 5 | ||||
| -rw-r--r-- | src/modules.c | 7 | ||||
| -rw-r--r-- | version.log | 6 |
3 files changed, 9 insertions, 9 deletions
@@ -2,8 +2,8 @@ Anope Version S V N ------------------- Provided by Anope Dev. <dev@anope.org> - 2004 12/30 A Warnings for NULL values with sstrdup/moduleData. [#261] -12/26 A Services can enforce SGLINE and SQLINE by killing the user on set [#245] -12/25 A Flag to tell if we need to enforce SGlines or not [ #00] +12/26 A Services can enforce SGLINE/SQLINE by killing the user on set. [#245] +12/25 A Flag to tell if we need to enforce SGlines or not. [ #00] 12/02 A Support for other Ulines Servers (NeoStats/SolarStats). [ #00] 11/28 A Support for Unreal's version of SVSHOLD. [ #00] 11/28 A /OS SET LIST to list the set options. [ #00] @@ -16,6 +16,7 @@ Provided by Anope Dev. <dev@anope.org> - 2004 11/19 A Added anope_cmd_ctcp() to code API, for sending CTCP messages. [ #00] 11/18 A Unable to use registered nicknames as bot nicks from now on. [ #00] 11/18 A NSAddAccessOnReg to control access list on registration. [ #00] +12/30 F Fixed moduleAddData using an old moduleData as list head. [#261] 12/30 F List handling of moduleData was bad on deletion. [#261] 12/30 F Few memleaks with moduleData functions returning early. [ #00] 12/30 F Modules can no longer add commands with mod_name set. [#261] diff --git a/src/modules.c b/src/modules.c index 4fa4c2c77..ddaa609d7 100644 --- a/src/modules.c +++ b/src/modules.c @@ -1825,7 +1825,6 @@ int moduleAddData(ModuleData ** md, char *key, char *value) */ char *mod_name = sstrdup(mod_current_module_name); ModuleData *newData = NULL; - ModuleData *tmp = *md; if (!key || !value) { alog("A module tried to use ModuleAddData() with one ore more NULL arguments... returning"); @@ -1850,11 +1849,7 @@ int moduleAddData(ModuleData ** md, char *key, char *value) newData->moduleName = sstrdup(mod_name); newData->key = sstrdup(key); newData->value = sstrdup(value); - if (tmp) { - newData->next = tmp; - } else { - newData->next = NULL; - } + newData->next = *md; *md = newData; free(mod_name); diff --git a/version.log b/version.log index 19fc24936..b3e4c253c 100644 --- a/version.log +++ b/version.log @@ -8,10 +8,14 @@ VERSION_MAJOR="1" VERSION_MINOR="7" VERSION_PATCH="6" -VERSION_BUILD="515" +VERSION_BUILD="516" # $Log$ # +# BUILD : 1.7.6 (516) +# BUGS : 261 +# NOTES : This should be it finally! The moduleAddData function was using the old head to append/prepend the new moduleData to, but it had to use the new head. Thanks to DrStein for finding the cause! :) +# # BUILD : 1.7.6 (515) # BUGS : 261 # NOTES : Fixed a few memleaks with moduleData functions returning early, and fixed the list handling with deleting moduleData (thanks DrStein) |