Remove the rest of the 1.8 logic "let's write all of the command handler with no return statement!"

Fix if (something) else if (!something) tests
Remove returns at the bottom of void functions

1 files changed, 10 insertions, 9 deletions

diff --git a/modules/commands/cs_akick.cpp b/modules/commands/cs_akick.cpp
index 435373810..9f69810fc 100644
--- a/modules/commands/cs_akick.cpp
+++ b/modules/commands/cs_akick.cpp
@@ -418,19 +418,20 @@ class CommandCSAKick : public Command
 		}
 
 		if (list.IsEmpty())
-			source.Reply(_("No matching entries on %s autokick list."), ci->name.c_str());
-		else
 		{
-			std::vector<Anope::string> replies;
-			list.Process(replies);
+			source.Reply(_("No matching entries on %s autokick list."), ci->name.c_str());
+			return;
+		}
 
-			source.Reply(_("Autokick list for %s:"), ci->name.c_str());
+		std::vector<Anope::string> replies;
+		list.Process(replies);
 
-			for (unsigned i = 0; i < replies.size(); ++i)
-				source.Reply(replies[i]);
+		source.Reply(_("Autokick list for %s:"), ci->name.c_str());
 
-			source.Reply(_("End of autokick list"));
-		}
+		for (unsigned i = 0; i < replies.size(); ++i)
+			source.Reply(replies[i]);
+
+		source.Reply(_("End of autokick list"));
 	}
 
 	void DoList(CommandSource &source, ChanServ::Channel *ci, const std::vector<Anope::string> &params)