Don't dynamically allocate commands in modules anymore, instead made them members of modules. This means the commands are automatically destructed when the module is unloaded. Cleans up some old ugly code.

1 files changed, 7 insertions, 3 deletions

diff --git a/modules/core/os_news.cpp b/modules/core/os_news.cpp
index 42ca764c3..03cfe3603 100644
--- a/modules/core/os_news.cpp
+++ b/modules/core/os_news.cpp
@@ -398,15 +398,19 @@ class CommandOSRandomNews : public NewsBase
 
 class OSNews : public Module
 {
+	CommandOSLogonNews commandoslogonnews;
+	CommandOSOperNews commandosopernews;
+	CommandOSRandomNews commandosrandomnews;
+
  public:
 	OSNews(const Anope::string &modname, const Anope::string &creator) : Module(modname, creator)
 	{
 		this->SetAuthor("Anope");
 		this->SetType(CORE);
 
-		this->AddCommand(OperServ, new CommandOSLogonNews());
-		this->AddCommand(OperServ, new CommandOSOperNews());
-		this->AddCommand(OperServ, new CommandOSRandomNews());
+		this->AddCommand(OperServ, &commandoslogonnews);
+		this->AddCommand(OperServ, &commandosopernews);
+		this->AddCommand(OperServ, &commandosrandomnews);
 
 		Implementation i[] = { I_OnUserModeSet, I_OnUserConnect, I_OnDatabaseRead, I_OnDatabaseWrite };
 		ModuleManager::Attach(i, this, 4);