diff options
| author | Sadie Powell <sadie@witchery.services> | 2024-11-11 16:46:56 +0000 |
|---|---|---|
| committer | Sadie Powell <sadie@witchery.services> | 2024-11-11 16:46:56 +0000 |
| commit | 96ccfe4cbe9948206ac2d6854778f9a268d2476f (patch) | |
| tree | 1e2059a204088051b0155b58de56bacaa2bfd58e /modules/extra/stats/irc2sql/irc2sql.cpp | |
| parent | ee160842b3ccab37f005c16a8657781e0e0412fd (diff) | |
Fix using User::Account where User::IsIdentified should be used.
The former causes a dereference which cause a database update. This
is not good for performance with db_sql_live on bigger networks.
Diffstat (limited to 'modules/extra/stats/irc2sql/irc2sql.cpp')
| -rw-r--r-- | modules/extra/stats/irc2sql/irc2sql.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/extra/stats/irc2sql/irc2sql.cpp b/modules/extra/stats/irc2sql/irc2sql.cpp index 8377c5d2e..391fad050 100644 --- a/modules/extra/stats/irc2sql/irc2sql.cpp +++ b/modules/extra/stats/irc2sql/irc2sql.cpp @@ -108,7 +108,7 @@ void IRC2SQL::OnUserConnect(User *u, bool &exempt) query.SetValue("ident", u->GetIdent()); query.SetValue("vident", u->GetVIdent()); query.SetValue("secure", u->HasMode("SSL") || u->HasExt("ssl") ? "Y" : "N"); - query.SetValue("account", u->Account() ? u->Account()->display : ""); + query.SetValue("account", u->IsIdentified() ? u->Account()->display : ""); query.SetValue("fingerprint", u->fingerprint); query.SetValue("signon", u->signon); query.SetValue("server", u->server->GetName()); @@ -176,7 +176,7 @@ void IRC2SQL::OnUserLogin(User *u) { query = "UPDATE `" + prefix + "user` SET account=@account@ WHERE nick=@nick@"; query.SetValue("nick", u->nick); - query.SetValue("account", u->Account() ? u->Account()->display : ""); + query.SetValue("account", u->IsIdentified() ? u->Account()->display : ""); this->RunQuery(query); } |