diff options
| author | Sadie Powell <sadie@witchery.services> | 2024-11-11 16:46:56 +0000 |
|---|---|---|
| committer | Sadie Powell <sadie@witchery.services> | 2024-11-11 16:46:56 +0000 |
| commit | 96ccfe4cbe9948206ac2d6854778f9a268d2476f (patch) | |
| tree | 1e2059a204088051b0155b58de56bacaa2bfd58e /modules/pseudoclients | |
| parent | ee160842b3ccab37f005c16a8657781e0e0412fd (diff) | |
Fix using User::Account where User::IsIdentified should be used.
The former causes a dereference which cause a database update. This
is not good for performance with db_sql_live on bigger networks.
Diffstat (limited to 'modules/pseudoclients')
| -rw-r--r-- | modules/pseudoclients/memoserv.cpp | 2 | ||||
| -rw-r--r-- | modules/pseudoclients/nickserv.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/modules/pseudoclients/memoserv.cpp b/modules/pseudoclients/memoserv.cpp index 8019086c6..cdfa93599 100644 --- a/modules/pseudoclients/memoserv.cpp +++ b/modules/pseudoclients/memoserv.cpp @@ -100,7 +100,7 @@ class MemoServCore : public Module, public MemoServService if (ci->AccessFor(cu->user).HasPriv("MEMO")) { - if (cu->user->Account() && cu->user->Account()->HasExt("MEMO_RECEIVE")) + if (cu->user->IsIdentified() && cu->user->Account()->HasExt("MEMO_RECEIVE")) cu->user->SendMessage(MemoServ, MEMO_NEW_X_MEMO_ARRIVED, ci->name.c_str(), Config->StrictPrivmsg.c_str(), MemoServ->nick.c_str(), ci->name.c_str(), mi->memos->size()); } } diff --git a/modules/pseudoclients/nickserv.cpp b/modules/pseudoclients/nickserv.cpp index 8bed39bba..bb4b3d305 100644 --- a/modules/pseudoclients/nickserv.cpp +++ b/modules/pseudoclients/nickserv.cpp @@ -399,7 +399,7 @@ class NickServCore : public Module, public NickServService const NickAlias *na = NickAlias::Find(u->nick); const Anope::string &unregistered_notice = Config->GetModule(this)->Get<const Anope::string>("unregistered_notice"); - if (!Config->GetModule("nickserv")->Get<bool>("nonicknameownership") && !unregistered_notice.empty() && !na && !u->Account()) + if (!Config->GetModule("nickserv")->Get<bool>("nonicknameownership") && !unregistered_notice.empty() && !na && !u->IsIdentified()) u->SendMessage(NickServ, unregistered_notice.replace_all_cs("%n", u->nick)); else if (na && !u->IsIdentified(true)) this->Validate(u); |