BUILD : 1.7.8 (758) BUGS : 332 NOTES : FIXED: anope_event_away() doing dangerous things with ac/av, viagra had issues in notice_ops, anope_cmd_mode() used wrongly for dreamforge and ultimate2

git-svn-id: svn://svn.anope.org/anope/trunk@758 31f1291d-b8d6-0310-a050-a5561fc1590b


git-svn-id: http://anope.svn.sourceforge.net/svnroot/anope/trunk@520 5417fbe8-f217-4b02-8779-1006273d7864

1 files changed, 11 insertions, 11 deletions

diff --git a/src/protocol/dreamforge.c b/src/protocol/dreamforge.c
index 6c77608f5..7632a08f9 100644
--- a/src/protocol/dreamforge.c
+++ b/src/protocol/dreamforge.c
@@ -152,9 +152,13 @@ void dreamforge_set_umode(User * user, int ac, char **av)
 
     while (*modes) {
 
-        add ? (user->mode |= umodes[(int) *modes]) : (user->mode &=
-                                                      ~umodes[(int)
-                                                              *modes]);
+		/* This looks better, much better than "add ? (do_add) : (do_remove)".
+		* At least this is readable without paying much attention :) -GD
+		*/
+		if (add)
+			user->mode |= umodes[(int) *modes];
+		else
+			user->mode &= ~umodes[(int) *modes];
 
         switch (*modes++) {
         case '+':
@@ -648,15 +652,11 @@ void dreamforge_cmd_global(char *source, char *buf)
 
 int anope_event_away(char *source, int ac, char **av)
 {
-    if (ac) {
-        return MOD_CONT;
-    }
-
     if (!source) {
         return MOD_CONT;
     }
-    m_away(source, av[0]);
-    return MOD_CONT;
+	m_away(source, (ac ? av[0] : NULL));
+	return MOD_CONT;
 }
 
 int anope_event_topic(char *source, int ac, char **av)
@@ -1041,7 +1041,7 @@ void dreamforge_cmd_bot_nick(char *nick, char *user, char *host,
     EnforceQlinedNick(nick, s_BotServ);
     send_cmd(NULL, "NICK %s 1 %ld %s %s %s 0 :%s", nick,
              (long int) time(NULL), user, host, ServerName, real);
-    anope_cmd_mode(nick, "MODE %s %s", nick, modes);
+    anope_cmd_mode(nick, nick, "MODE %s", modes);
     dreamforge_cmd_sqline(nick, "Reserved for services");
 }
 
@@ -1095,7 +1095,7 @@ void dreamforge_cmd_guest_nick(char *nick, char *user, char *host,
 {
     send_cmd(NULL, "NICK %s 1 %ld %s %s %s 0 :%s", nick,
              (long int) time(NULL), user, host, ServerName, real);
-    anope_cmd_mode(nick, "MODE %s %s", nick, modes);
+    anope_cmd_mode(nick, nick, "MODE %s", modes);
 }
 
 void dreamforge_cmd_svso(char *source, char *nick, char *flag)